envelope: Rely on stdlib for decoding to UTF-8 #234
Merged
+97
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update AddressList to rely on stdlib for decoding to UTF-8. This is an inverted approach to that of #219
I also extracted & exposed our parser and added unit tests so we don't have to add testdata file based tests for all address list scenarios.
While Go's address parsing has improved significantly since the initial release of enmime, it's possible we will still run into some regressions. If that happens we can add a fall-back to using our own rfc2047 decoder.
Closes #218