fix(meditype): remove trailing HTML tags #252
Merged
+93
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytrokasianenko-outreach
force-pushed
the
dmytrokasianenko-outreach/fix/remove-trainling-tags
branch
3 times, most recently
from
02204de to
0421544
Compare
jhillyerd
requested changes
May 26, 2022
dmytrokasianenko-outreach
force-pushed
the
dmytrokasianenko-outreach/fix/remove-trainling-tags
branch
from
0421544 to
2316cc1
Compare
jhillyerd
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to fix removing trailing HTML tag in MIME media part.
There is a problem with boundaries that are looking like
multipart/alternative; boundary="<<<<boundary".Current implementation was removing everything after
<symbol, so it looks likemultipart/alternative; boundary="", ending up with errorunable to locate boundary param in Content-Type.Hope I've covered most possible cases in tests.