Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jhipster 7.0.1 and couchbase 7 #14745

Closed
blackxMan opened this issue Apr 22, 2021 · 12 comments · Fixed by #17822
Closed

Jhipster 7.0.1 and couchbase 7 #14745

blackxMan opened this issue Apr 22, 2021 · 12 comments · Fixed by #17822

Comments

@blackxMan
Copy link

Hello,
is there any chance to support couchbase 7 with scopes & collections feature.
thank you

@mraible
Copy link
Contributor

mraible commented Apr 22, 2021

If you're willing to do the work, we'd love to have Couchbase support! We dropped it from JHipster 7 because we found Spring Data's support wasn't that great with Spring Boot 2.3 and 2.4.

See #14184 for more information.

@blackxMan
Copy link
Author

hey @mraible,
Thanks for answer, i think they fix all problem in the new version Spring Data Couchbase 4.0 based on couchbase sdk 3

@mraible
Copy link
Contributor

mraible commented Apr 23, 2021

@blackxMan If you'd like to see Couchbase support re-added, you're more than welcome to fork my repo and contribute to the fix-couchbase branch. I've spent too many hours on it and I'm no longer interested in working on it.

@murdos
Copy link
Contributor

murdos commented Apr 23, 2021

i think they fix all problem in the new version Spring Data Couchbase 4.0 based on couchbase sdk 3

On the contrary, things go broken since Spring Data Couchbase 4.0 release.
I also spent too many hours trying to fix it.

@coderguy-tech
Copy link

coderguy-tech commented May 22, 2021

Hey,
I'm working on this right now:

  1. Updating JHipster codebase to use the new version of Spring Data Couchbase 4 based on Couchbase SDK 3
  2. Re-wiring some of the older code (wherever CB related database code is) to ensure that it works with Spring Data and Couchbase SDK API calls.
  3. Running through the test suites of JHipster to ensure that they pass — as I hit failures in the tests, I'll keep resolving these issues as I go along

If I need help or get stuck along the way, will reach out.
Thanks

@DanielFran
Copy link
Member

DanielFran commented May 22, 2021

@coderguy-tech do not forget #14184, you can continue based on that...

@coderguy-tech
Copy link

Thanks, I'll take a look at that

@gkysaad
Copy link
Contributor

gkysaad commented Jun 10, 2021

As I was working on the fix I came across an issue with the Couchmove implementation. Couchbase's SearchIndex class' toJson() function does not output all of the custom data used to create a SearchIndex object, resulting in FTS indices not being created properly with all the required data in the database. So, I've created a custom SearchIndex class and created a PR in the couchmove repo to fix this bug there: tchlyah/couchmove#13.

@DanielFran
Copy link
Member

DanielFran commented Jun 23, 2021

@gkysaad I merged on BOM the update to couchmove 3.1.1

@gkysaad @coderguy-tech Fill free to continue the work started on couchbase migration for spring-boot 2.4+ in #14184

@gkysaad
Copy link
Contributor

gkysaad commented Jun 23, 2021

Thanks @DanielFran! I've been working based on the branch in #14184 but I'm working off a new branch that's rebased with jhipster:main as the changes on that branch were way behind the latest code and thus led to too many merge conflicts when I tried to rebase.

gkysaad added a commit to gkysaad/generator-jhipster that referenced this issue Jul 14, 2021
@gkysaad
Copy link
Contributor

gkysaad commented Jul 14, 2021

I've created a PR (#15645) with my fixes and implementation for Spring Data Couchbase 4.

gkysaad added a commit to gkysaad/generator-jhipster that referenced this issue Aug 13, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.
Our core developers tend to be more verbose on denying. If there is no negative comment, possibly this feature will be accepted.
We are accepting PRs 😃.
Comment or this will be closed in 7 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants