Add composing component priority. #26080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshima
changed the title
mshima
force-pushed
the
composing-component
branch
from
7676e14
to
ee899a0
Compare
mshima
force-pushed
the
composing-component
branch
from
ab31a5c
to
f2d5b26
Compare
mshima
commented
May 9, 2024
| it('should match order', () => { | ||
| expect(runResult.askedQuestions.map(({ name }) => name)).toMatchInlineSnapshot(` | ||
| [ | ||
| "baseName", |
| expect(runResult.askedQuestions.map(({ name }) => name)).toMatchInlineSnapshot(` | ||
| [ | ||
| "baseName", | ||
| "applicationType", |
| [ | ||
| "baseName", | ||
| "applicationType", | ||
| "packageName", |
| "baseName", | ||
| "applicationType", | ||
| "packageName", | ||
| "buildTool", |
Comment on lines
+181
to
+189
| "reactive", | ||
| "authenticationType", | ||
| "serverTestFrameworks", | ||
| "databaseType", | ||
| "prodDatabaseType", | ||
| "devDatabaseType", | ||
| "cacheProvider", | ||
| "enableHibernateCache", | ||
| "serverSideOptions", |
generators/app/generator.spec.ts
Outdated
Comment on lines
190
to
192
| "enableTranslation", | ||
| "nativeLanguage", | ||
| "languages", |
Comment on lines
+193
to
+196
| "clientFramework", | ||
| "clientTestFrameworks", | ||
| "withAdminUi", | ||
| "clientTheme", |
mshima
force-pushed
the
composing-component
branch
from
48f62ef
to
f1d66fb
Compare
DanielFran
approved these changes
May 14, 2024
Tcharl
reviewed
May 19, 2024
| }); | ||
|
|
||
| it('should match order', () => { | ||
| expect(runResult.askedQuestions.map(({ name }) => name)).toMatchInlineSnapshot(` |
There was a problem hiding this comment.
Locally running npm test, the askedQuestion returns undefined. Any clue?
There was a problem hiding this comment.
npm ci?
Requires an updated version of yeoman-test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new priority to improve prompts order.
This will allow to configure (initialize, prompt, configure and compose) every backend generator before client generators.
Related to #26057 (comment) and fixes #26079.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.