Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonar: 49 reliability issues #26106

Closed
qmonmert opened this issue May 10, 2024 · 2 comments · Fixed by #26107
Closed

Sonar: 49 reliability issues #26106

qmonmert opened this issue May 10, 2024 · 2 comments · Fixed by #26107
Assignees
@qmonmert
Labels
theme: sonar

Comments

@qmonmert
Copy link
Contributor

https://sonarcloud.io/project/issues?impactSoftwareQualities=RELIABILITY&resolved=false&id=jhipster-sample-application

image
@qmonmert qmonmert self-assigned this May 10, 2024
@qmonmert qmonmert mentioned this issue May 10, 2024
Merged
6 tasks
@mshima
Copy link
Member

mshima commented May 10, 2024

IMO 42 of 49 are false positives.
Doesn’t make sense to require keypress on aria-hidden elements that are not focusable.

@qmonmert
Copy link
Contributor Author

@mshima ok I remove the 42 on the PR

@mshima mshima mentioned this issue May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qmonmert qmonmert

Labels
theme: sonar
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sonar: Add a 'onKeyPress|onKeyDown|onKeyUp' attribute to this <span> tag qmonmert/generator-jhipster
2 participants
@mshima @qmonmert