Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop coverage for fullapp #4172

Closed
pascalgrimaud opened this issue Oct 29, 2022 · 5 comments
Closed

Drop coverage for fullapp #4172

pascalgrimaud opened this issue Oct 29, 2022 · 5 comments
Labels
area: bug 🐛 Something isn't working theme: client

Comments

@pascalgrimaud
Copy link
Member

See the sonar analysis for the fullapp:

image

I think it's related to the migration from jest to vitest :-(
So finally, I'm not sure about this move, it looks like vitest is not really ready

cc @Gnuk @qmonmert
@pascalgrimaud pascalgrimaud added area: bug 🐛 Something isn't working theme: client labels Oct 29, 2022
@qmonmert
Copy link
Contributor

@pascalgrimaud which line is not covered?

@pascalgrimaud
Copy link
Member Author

Sorry, power off my computer. I think it's the homepage.component.ts
Maybe it could be fixed by vitest team. Let's wait, as I think the issue comes from there.

This issue is just to track this item

@qmonmert
Copy link
Contributor

ok tell me tomorrow

@Gnuk
Copy link
Contributor

Gnuk commented Oct 29, 2022

I just link the PR from vitest relative to the fix: vitest-dev/vitest#2232

@qmonmert qmonmert mentioned this issue Oct 30, 2022
Merged
@DamnClin
Copy link
Collaborator

DamnClin commented Nov 1, 2022

Fixed on main, just run a check

@DamnClin DamnClin closed this as completed Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: bug 🐛 Something isn't working theme: client
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Gnuk @pascalgrimaud @qmonmert @DamnClin