Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

HUGE error on solveFor #670

Open
Matt0017 opened this issue May 23, 2022 · 1 comment
Open

HUGE error on solveFor #670

Matt0017 opened this issue May 23, 2022 · 1 comment

Comments

@Matt0017
Copy link

a very simple

x*y+y=0

solved for x return two answers:
x=-1 (correct) and x=0 (incorrect)

@Matt0017
Copy link
Author

Debugging I found that this was being transformed into

(x+1)*y
that first part gives the correct answer -1
but solving y for x returns 0, which may be the problem of a missing pair of parenthesis in Solve.js line 1328
if(eq.group === S || eq.group === CB && eq.contains(solve_for))
in this case
eq.group === S is true and eq.contains(solve_for) is false
but the whole condition is true

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant