-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
async support #41
Comments
I think we should do something, because having to have two retry crates isn't super sensible; but we probably need to be smart about the runtime binding to sleep(); since we shouldn't block the thread, but -last I checked - core rust doesn't define a sleep async primitive. |
Maybe can use some dependency injection here? So the caller can specify what sleep api to call, be it Edit: I guess #28 is using dependency injection here |
I'm personally not inclined to develop this crate further. I think async retries should be in a separate crate. But since I'm not very active in free software development anymore, I won't stop the other folks with repo/crate access if they want to build and maintain it. |
@jimmycuadra any chanced we could get #44 merged? |
I just came across this library and I definitely would want to use it but I can't because it doesn't support futures.
I know there are a couple of implementations as PRs already but I'm opening this to push for a decision now that the async ecosystem is probably mature enough.
The text was updated successfully, but these errors were encountered: