Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async support #41

Open
IGI-111 opened this issue Oct 14, 2021 · 4 comments
Open

async support #41

IGI-111 opened this issue Oct 14, 2021 · 4 comments

Comments

@IGI-111
Copy link

IGI-111 commented Oct 14, 2021

I just came across this library and I definitely would want to use it but I can't because it doesn't support futures.

I know there are a couple of implementations as PRs already but I'm opening this to push for a decision now that the async ecosystem is probably mature enough.

@rbtcollins
Copy link
Collaborator

I think we should do something, because having to have two retry crates isn't super sensible; but we probably need to be smart about the runtime binding to sleep(); since we shouldn't block the thread, but -last I checked - core rust doesn't define a sleep async primitive.

@cbeck88
Copy link

cbeck88 commented Jun 9, 2022

Maybe can use some dependency injection here? So the caller can specify what sleep api to call, be it tokio::time::sleep or something else?


Edit: I guess #28 is using dependency injection here

@jimmycuadra
Copy link
Owner

I'm personally not inclined to develop this crate further. I think async retries should be in a separate crate. But since I'm not very active in free software development anymore, I won't stop the other folks with repo/crate access if they want to build and maintain it.

@clarkmcc
Copy link

@jimmycuadra any chanced we could get #44 merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants