Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncoid Dry Run Options #11

Open
gdevenyi opened this issue Aug 11, 2015 · 4 comments · May be fixed by #748
Open

Syncoid Dry Run Options #11

gdevenyi opened this issue Aug 11, 2015 · 4 comments · May be fixed by #748

Comments

@gdevenyi
Copy link
Contributor

I want to see that my configuration is correct, or see what syncoid will do before I do it. A dry run option would be nice.

@jimsalterjrs jimsalterjrs changed the title Dry Run Options Syncoid Dry Run Options May 23, 2016
@jimsalterjrs jimsalterjrs added this to the 1.4.9 milestone May 23, 2016
@mailinglists35
Copy link

i'd like to see this, too! :)

@mailinglists35
Copy link

hi,
just a reminder
thanks

@phreaker0 phreaker0 removed this from the 1.4.9 milestone Oct 20, 2018
@mailinglists35
Copy link

hey guys, is this thing difficult to implement?

@Zixim
Copy link

Zixim commented Jan 18, 2020

this would be great to have.

anarcat added a commit to anarcat/sanoid that referenced this issue May 30, 2022
This is a little messy: that includes a *lot* of whitespace change,
but I couldn't really figure out a better way to do it, in general.

(A better way would have been something like:

    if ($args{'dryrun'}) return 0;

... but the functions are generally too long for that kind of hack to
work at all. Alternatively, I figured it might be good to have a
generic `system()` wrapper, but I haven't dug deep enough in the code
to see if it's always called the same way, or if that would make
sense.)

This doesn't block *all* `system()` calls either: only those who
actually make changes. SSH setup commands and commands that just probe
the snapshot lists are let through, so this is not completely a
`--noop` flag (hence the `--dryrun` instead), because it
actually *does* some things still.

I have only grepped for `system()` and haven't audited the entire
source code to see if other side effects (e.g. creating files) also
exist.

Disclaimer: this patch was briefly tested on my home system, and my
level of familiarity with sanoid is "beginner".

Closes: jimsalterjrs#11
@anarcat anarcat linked a pull request May 30, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants