Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Electron 14 #629

Closed
vchernin opened this issue Sep 3, 2021 · 10 comments · Fixed by #673
Closed

Upgrade to Electron 14 #629

vchernin opened this issue Sep 3, 2021 · 10 comments · Fixed by #673
Assignees

Comments

@vchernin
Copy link

vchernin commented Sep 3, 2021

Electron 14 includes a very notable addition: electron/electron#19159

It means users on KDE or other desktop environments will get the native Qt file picker instead of the GTK one. Also, it means the Jitsi Flatpak can pick any file with the file picker without granting unilateral file system access.

I tried building it locally but failed likely due to inexperience.

@csett86
Copy link
Member

csett86 commented Sep 3, 2021

Unfortunately electron 14 also removes the deprected remote module. That is used both in dependencies and in jitsi-meet-electron, so it has to be replaced everywhere before Electron 14 is feasible

@vchernin
Copy link
Author

vchernin commented Sep 3, 2021

Ah, I think I might have run into that.

I guess since it's depended on there's no easy way of forcing it to build (and it being actually succesful).

@csett86
Copy link
Member

csett86 commented Sep 18, 2021

In between I at least discovered all the issues that need to be fixed before the electron 14 update is possible:

@csett86 csett86 self-assigned this Sep 18, 2021
@saghul
Copy link
Member

saghul commented Sep 18, 2021

Fantastic work!

@romain130492
Copy link

any news about Make robotjs context-aware ?

@ilippert
Copy link

Please note that on Fedora 35, this jitsi app does not run anymore - because on wayland it now only shows a black window. I think it is the same issue with other apps not using Electron 14. See e.g. element-hq/element-desktop#728

So, Electron 14 would be really great.

@saghul
Copy link
Member

saghul commented Nov 26, 2021

any news about Make robotjs context-aware ?

This work has been completed already.

Please note that on Fedora 35, this jitsi app does not run anymore - because on wayland it now only shows a black window. I think it is the same issue with other apps not using Electron 14. See e.g. vector-im/element-desktop#728 (comment)

So, Electron 14 would be really great.

We are already ready, thanks to the relentless work @csett86 has put into it. We are waiting a bit because the update may break backwards compatibility (lost settings) for some people, unless they are currently running the latest version, which has some migration code path in.

@ilippert
Copy link

We are already ready, thanks to the relentless work @csett86 has put into it. We are waiting a bit because the update may break backwards compatibility (lost settings) for some people, unless they are currently running the latest version, which has some migration code path in.

thank you so much for the update, and for the work! A great app!

csett86 added a commit that referenced this issue Dec 1, 2021
Contains:

- Chromium 91 -> 96, including multiple webrtc and security fixes
- Linux file chooser portal fixes (electron/electron#19159)

Closes: #629
@csett86
Copy link
Member

csett86 commented Dec 1, 2021

Released as v2021.12.1

@WhyNotHugo
Copy link

Thanks a lot for addressing this!

d3473r pushed a commit to d3473r/jitsi-meet-electron that referenced this issue Sep 1, 2023
Contains:

- Chromium 91 -> 96, including multiple webrtc and security fixes
- Linux file chooser portal fixes (electron/electron#19159)

Closes: jitsi#629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants