Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes RaiseHand label ParticipantPane issue #14579

Open
astro-dally opened this issue Mar 30, 2024 · 5 comments · May be fixed by #14580
Open

Fixes RaiseHand label ParticipantPane issue #14579

astro-dally opened this issue Mar 30, 2024 · 5 comments · May be fixed by #14580

Comments

@astro-dally
Copy link

astro-dally commented Mar 30, 2024 •
edited

Description:

When a user clicks on the raisehand button which is shown on the top it shows the participants pane.

Steps to reproduce:

  1. Create a jitsi meet
  2. Click on raisehand
  3. After clicking on the top a raisehand icon will appear
  4. Click on the raisehand icon on the top

Expected behavior:

When a user clicks on the raisehand button which is shown on the top, it shows all participants pane.

RaiseHandParticipants

Actual behavior:

On clicking the raisehand icon, only the participants who have raised their hand should appear

Participants

Server information:

  • Jitsi Meet version: 2.0.9364
  • Operating System: MacBook Pro Apple M2

Client information:

  • Browser / app version: Chrome Version 123.0.6312.87
  • Operating System: MacBook Pro Apple M2

Additional information:

I have attached the demo video,

demoVideo.mp4
@astro-dally astro-dally linked a pull request Mar 30, 2024 that will close this issue
Open
@damencho
Copy link
Member

And how do you get out of this mode for the participants pane?

@astro-dally
Copy link
Author

Currently when the user clicks on the "Show Participants" icon, the default participants pane is displayed. However, when the user clicks on the "Raise Hand" icon, it shows the participants with raised hands.

Could you provide suggestions on how to manage the switching between modes?

@astro-dally
Copy link
Author

Is the current approach correct?
or Should we have different components to handle different modes?

@damencho
Copy link
Member

damencho commented Apr 1, 2024

@saghul wdyt?

@saghul
Copy link
Member

saghul commented Apr 4, 2024

I think the UX complexity this adds is not great. The raised hand users are already sorted to the top, so that's not a problem for large meetings.

This should be evaluated in the context of the GSoC speaker queue project, not ad-hoc, IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Raise hand sidebar fix astro-dally/jitsi-meet
3 participants
@saghul @damencho @astro-dally