Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNSDK] Duplicates of @react-native/metro-config package in dependencies and devDependencies #14717

Closed
danilvalov opened this issue May 6, 2024 · 2 comments · Fixed by #14739

Comments

@danilvalov
Copy link

Description:

When I run prepare_sdk.js script after installation/updating I see duplicates of @react-native/metro-config dependency in my package.json:

  1. Original React Native dependency in devDependencies section: github/react-native
  2. Jitsi dependency in dependencies section: github/jitsi-meet

And there is a conflict of versions because:

  • my react-native: "0.72.14" (latest stable version) uses @react-native/metro-config: "0.72.12"
  • Jitsi RN SDK uses @react-native/metro-config: "0.72.9".

Jitsi doesn't update a version of @react-native/metro-config, just adds a new dependency.

P.S. I don't sure it is correct to overwrite a React Native dependency

@saghul
Copy link
Member

saghul commented May 6, 2024

Thanks for the report! @Calinteodor can you PTAL when you're back?

@Calinteodor
Copy link
Contributor

@danilvalov Thanks again for the report! Fix will be available in the next React Native SDK release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants