Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a potential bug on resolving provider's token - mismatching logic from nestjs core and this package #51

Open
micalevisk opened this issue Oct 12, 2023 · 0 comments

Comments

@micalevisk
Copy link
Contributor

micalevisk commented Oct 12, 2023

here we have the following:

private static tokenIsOptionalToken(
token: InjectionToken | OptionalFactoryDependency,
): token is OptionalFactoryDependency {
return !!(token as any)['token'];
}

but at nestjs side, I found 2 places where x is OptionalFactoryDependency is being used:

image

image

both of them aren't equal to the logic that nestjs-spelunker has. I wonder if this is expected

@micalevisk micalevisk changed the title maybe a bug on resolving provider's token a potential bug on resolving provider's token - mismatch logic from nestjs core and this package Dec 30, 2023
@micalevisk micalevisk changed the title a potential bug on resolving provider's token - mismatch logic from nestjs core and this package a potential bug on resolving provider's token - mismatching logic from nestjs core and this package Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant