You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
first of all, thank you for this amazing project that is well design and beloved by us (and others for sure 鉂わ笍 )
Is there an existing issue that is already proposing this?
I have searched the existing issues
Is your feature request related to a problem? Please describe it
We would like to add tenantId in OgmaLogger Interceptor (GraphQL and Express one) to be able to filters in our logs tool (Datadog) and create some dashboards to see the requests per tenantId.
To do this, we need to have this data in the logs of the request.
Describe the solution you'd like
We saw and play with extending the Parser and then use the getMeta from the doc here but it creates a new log that doesn't contains information on the request, the time, ...
Ideally, we would like to have one log per request but be able to add additional properties such as tenantId.
The extends pattern is good, a factory could be great to inject service (ContextService) that will set extra properties. But the main point is to be able to have one log entry.
We could keep the getMeta for extra logs and create a new extraProperties method to handle this use-case
We could BC and don't create an extra log with getMeta
We could add an extra optional param for getMeta - shouldCreateExtraLog = true default to true
What is the motivation / use case for changing the behavior?
We think this is a must have changes for any multi-tenant apps that wants to have better observability per tenant. This could also be great to easily enhanced and add more custom properties to the request log (userId to see activity per user, apiKeyId same but scoped per apiKey).
The text was updated successfully, but these errors were encountered:
Hello there 馃憢 ,
first of all, thank you for this amazing project that is well design and beloved by us (and others for sure 鉂わ笍 )
Is there an existing issue that is already proposing this?
Is your feature request related to a problem? Please describe it
We would like to add
tenantId
in OgmaLogger Interceptor (GraphQL and Express one) to be able to filters in our logs tool (Datadog) and create some dashboards to see the requests pertenantId
.To do this, we need to have this data in the logs of the request.
Describe the solution you'd like
We saw and play with extending the Parser and then use the
getMeta
from the doc here but it creates a new log that doesn't contains information on the request, the time, ...Ideally, we would like to have one log per request but be able to add additional properties such as
tenantId
.The extends pattern is good, a factory could be great to inject service (
ContextService
) that will set extra properties. But the main point is to be able to have one log entry.Teachability, documentation, adoption, migration strategy
getMeta
for extra logs and create a newextraProperties
method to handle this use-casegetMeta
getMeta
-shouldCreateExtraLog = true
default totrue
What is the motivation / use case for changing the behavior?
We think this is a must have changes for any multi-tenant apps that wants to have better observability per tenant. This could also be great to easily enhanced and add more custom properties to the request log (userId to see activity per user, apiKeyId same but scoped per apiKey).
The text was updated successfully, but these errors were encountered: