Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin panel won't load for tenants that have slug with special characters #12

Open
joas8211 opened this issue May 7, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@joas8211
Copy link
Owner

joas8211 commented May 7, 2023

Admin panel front-end won't render for tenants that have slug with special characters. This happens when percent-encoding is used for the path.

@joas8211 joas8211 added the bug Something isn't working label May 7, 2023
joas8211 added a commit that referenced this issue May 7, 2023
@joas8211
Copy link
Owner Author

joas8211 commented May 7, 2023

I think it might be because React Router won't match the path correctly. This issue might be related: remix-run/react-router#10213

@joas8211
Copy link
Owner Author

joas8211 commented May 7, 2023

I think it might be because React Router won't match the path correctly. This issue might be related: remix-run/react-router#10213

Actually, Payload CMS uses version 5 of React Router DOM, so the issue might be already fixed in version 6 of the library.

@joas8211
Copy link
Owner Author

To fix this, it should be disallow to use a space character in tenant slug.

@joas8211 joas8211 self-assigned this Aug 1, 2023
@joas8211
Copy link
Owner Author

This still seems to be an issue. Other special characters are also causing problems. What I can see routing used in backend and frontend work differently. I'm considering to limit slugs to ASCII only.

@joas8211 joas8211 reopened this Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant