From abd8cbfd28c9fb933636d35fd8230f7725c2c3f6 Mon Sep 17 00:00:00 2001 From: Luigi Pinca Date: Thu, 8 Oct 2020 20:50:21 +0200 Subject: [PATCH] test: do not use the same EventEmitter instance MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Prevent multiple listeners for the `'error'` event to be added to the same `EventEmitter` instance. PR-URL: https://github.com/nodejs/node/pull/35560 Refs: https://github.com/nodejs/node/pull/35557#issuecomment-705476640 Reviewed-By: Anna Henningsen Reviewed-By: Gerhard Stöbich Reviewed-By: Michael Dawson Reviewed-By: Colin Ihrig Reviewed-By: Robert Nagy Reviewed-By: Rich Trott --- test/parallel/test-stream2-readable-wrap-error.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/test/parallel/test-stream2-readable-wrap-error.js b/test/parallel/test-stream2-readable-wrap-error.js index ac1f64f69810f0..a05ae8179b06ef 100644 --- a/test/parallel/test-stream2-readable-wrap-error.js +++ b/test/parallel/test-stream2-readable-wrap-error.js @@ -5,12 +5,14 @@ const assert = require('assert'); const Readable = require('_stream_readable'); const EE = require('events').EventEmitter; -const oldStream = new EE(); -oldStream.pause = () => {}; -oldStream.resume = () => {}; +class LegacyStream extends EE { + pause() {} + resume() {} +} { const err = new Error(); + const oldStream = new LegacyStream(); const r = new Readable({ autoDestroy: true }) .wrap(oldStream) .on('error', common.mustCall(() => { @@ -23,6 +25,7 @@ oldStream.resume = () => {}; { const err = new Error(); + const oldStream = new LegacyStream(); const r = new Readable({ autoDestroy: false }) .wrap(oldStream) .on('error', common.mustCall(() => {