Remove socket.inet_pton #318
Conversation
|
The ipaddress.IPv6Address inconsistency for older patch versions will disappear on its own when Python 3.9 goes EOL. |
|
GitHub Action setup-python for Windows does not have Python 3.8.12 or later. Should we skip the leading zeroes test for |
|
Yeah, skip it. Maybe it can be a single version |
| @@ -38,8 +38,7 @@ def md5(*args: bytes) -> hashlib._Hash: | |||
|
|
|||
|
|
|||
| def get_pkg_unique_identifier() -> str: | |||
| """ | |||
| Generate an identifier unique to the python version, tldextract version, and python instance. | |||
| """Generate an identifier unique to the python version, tldextract version, and python instance. | |||
There was a problem hiding this comment.
Do you know what generated these linebreak diffs? I'm just curious, to reduce noise in our tooling. The latest version of black . and ruff format . don't seem to care about this change either way.
There was a problem hiding this comment.
This happened here elliotwutingfeng@d7001c6. I was using ruff v0.2.1, but it doesn't seem to be causing it.
|
Thanks for hopping on this! |
|
Python versions where the ipaddress standard library erroneously accepts leading IPv4 zeroes in IPv4 addresses / IPv6 (dual) addresses.
Reference: https://docs.python.org/3/library/ipaddress.html#ipaddress.IPv4Address (referenced hyperlink is for ipaddress.IPv4Address but applies to ipaddress.IPv6Address dual addresses too) |
https://build.opensuse.org/request/show/1163368 by user mia + anag+factory - Update to 5.1.2: * Remove socket.inet_pton, to fix platform-dependent IP parsing #gh/john-kurkowski/tldextract#318 * Use non-capturing groups for IPv4 address detection, for a slight speed boost #gh/john-kurkowski/tldextract#323
Closes #317
Changes
Unresolved
I've also run checks on Python 3.8.7 which was affected by the leading zeroes inconsistency in the standard library method ipaddress.IPv4Address (see #292). It turns out ipaddress.IPv6Address is also affected by the same inconsistency (for trailing IPv4 portion).
I would propose copying the implementation of ipaddress.IPv6Address or some other implementation like the one in Go, modifying it to avoid the leading zeroes bug even on older Python versions, and removing portions that we don't need, like checks if input is of
strtype, though it means we will have to ensure that our implementation is up-to-date with upstream. Upside is we will have more control over parsing bugs.