Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build log full of keep entry IdentityCollection #334

Open
fchristysen opened this issue Mar 5, 2018 · 2 comments
Open

Build log full of keep entry IdentityCollection #334

fchristysen opened this issue Mar 5, 2018 · 2 comments

Comments

@fchristysen
Copy link

fchristysen commented Mar 5, 2018

I used parceler version '1.1.6' with proguard enabled. I have these proguard rules in my 'proguard-rules.pro' :
-keep interface org.parceler.Parcel -keep @org.parceler.Parcel class * { *; } -keep class **$$Parcelable { *; }
When I build the apk using terminal (or happen too with my Bitrise CI), the terminal output full of
Note: the configuration keeps the entry point 'someClass$$Parcelable { void write(someClass,android.os.Parcel,int,org.parceler.IdentityCollection); }', but not the descriptor class 'org.parceler.IdentityCollection'" logs. someClass represents class in my project that implement parceler.

This log cause a problem in my CI, since the log file becomes too big(2.2 MB), and cause the build to fail. I have to add another proguard rules "-keep class org.parceler.IdentityCollection", to make this notes disappear.

My question is, what is this IdentityCollection? and will it cause a problem if I keep the IdentityCollection class?

@johncarl81
Copy link
Owner

IdentityCollection is used to compare and determine uniqueness in a graph of objects during deserialization. Adding the proguard rule you mentioned is a good idea.

@johncarl81
Copy link
Owner

johncarl81 commented Mar 6, 2018

Should we add this to the suggested proguard configuration?

johnjohndoe added a commit to Umweltzone/Umweltzone that referenced this issue Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants