remove mbtiles tile provider + sqflite dependency #787
Conversation
|
Hey John, good thinking! I didn't consider the plugin system, was it already available back then? I'm quite busy nowadays, but I'll added it to my todolist and scheduled it for somewhere around xmas and new years eve. |
|
No worries, it might not have been available when this was added. I was having some trouble running on iOS with sqflite (#786) so I'm not sure how much effort it will take. |
* remove mbtiles and sqlflite dependency * remove mbtiles tile provider + sqflite dependency fixes fleaflet#786 * remove example/test/widget_test
* patched version * V0.10.2 * fix if PolylineOption.borderColor==null * Fixup build errors for the web example (#782) * Add new required environment spec Otherwise flutter throws an error and abort building. Fixes #774 * Update usage of API for text colors As suggested by joselbr2099 the API have changed in flutter. Replace only colors parameter with textColor. Fixes #774 * remove mbtiles tile provider + sqflite dependency (#787) * remove mbtiles and sqlflite dependency * remove mbtiles tile provider + sqflite dependency fixes #786 * remove example/test/widget_test * updated to latest master version * formatting code Co-authored-by: nickoe <oe.nick@gmail.com> Co-authored-by: John Ryan <ryjohn@google.com>
|
@johnpryan, @avbk I hope that no one from you guys is angry with me, but I needed this functionality, so I used code and have made a separate package with MBTilesProvider based on removed code from this repository. |
|
@DonWasyl these were contributed under a BSD license, so it's okay (from a licensing point of view) to publish it as a package. I would recommend adding a similar license to your package, though. |
|
Right. |
|
No, I believe these were added by @avbk |
|
Awesome, I didn't find any time to rewrite it as a plugin, yet. So I am glad that you put out the existing files on pub! |
|
@avbk Can I put this code to pub.dev? 🙂 |
|
Yeah I'd love to see it on pub! |
fixes #786
@avbk The dependency on sqlflite can cause problems for users who want to use flutter_map without the mbtiles provider. Since this is a map plugin, I think this code should be written as a separate package. That way, you would include flutter_map along with the new package, (e.g. flutter_map_mbtiles) and then use the MBTilesImageProvider from that package.
Would you like to make that package since you were the original author?