Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmet suggestions are showed inside tags (including top level) #1039

Closed
zardoy opened this issue Mar 13, 2022 · 3 comments
Closed

Emmet suggestions are showed inside tags (including top level) #1039

zardoy opened this issue Mar 13, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@zardoy
Copy link
Contributor

zardoy commented Mar 13, 2022

Steps to reproduce:

  1. Clone volar-starter
  2. Open src/components/HelloWorld.vue in line 25
  3. Remove setup word and type s
  4. Trigger suggestions

Actual: emmet suggestions are showed

Expected: not showing

image

  • tested in insiders with clean settings.json

Also, I don't remember that in previous version emmet suggestions were showing inside every tag in template and even in interpolations: try to type div after count in src\components\HelloWorld.vue:16

@johnsoncodehk johnsoncodehk added the bug Something isn't working label Mar 13, 2022
@number304
Copy link

Yes, in my case it doesn't even show any suggestions. :(

@zardoy
Copy link
Contributor Author

zardoy commented Mar 21, 2022

Thank you so much for resolving this! However I wonder is there a test to ensure that the bug won't rise again?

@johnsoncodehk
Copy link
Member

@zardoy Haven't had time to write tests before, there will be later. (PR is also welcome!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants