Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for template typed slots with defineComponent to reduce a half memory usage #1108

Closed
johnsoncodehk opened this issue Mar 25, 2022 · 0 comments · Fixed by #1152
Closed
Labels
enhancement New feature or request

Comments

@johnsoncodehk
Copy link
Member

johnsoncodehk commented Mar 25, 2022

For support template typed slots, we need to have 2 TS language services, one of which for bypasses regular DefineComponent type export to resolve #94, this is causes memory usage to double.

But now we already have script setup, support template typed slots with script setup will no have #94 problem, I planed to remove template TS language service instance in @volar/vue-typescript, and change template typed slots to only support for script setup. With regular defineComponent() component definition, you should always use $slots option to define slots type.

Reduce a half memory usage would be a major improvement for volar, but we need to wait for vuejs/core#2693 completed before migrating to the new typed slots implementation, @pikax is there any chance of this being done in the near future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant