$tsc & $tsc-watch problem matchers unavailable in take over mode

[segevfiner]

As the $tsc & $tsc-watch problem matchers, and associated patterns, are contributed by the TypeScript and JavaScript extension that you need to disable to switch to take over mode, they become unavailable in take over mode, while they could still be useful while in it.

[huzaifahj]

+1 for this, this task in tasks.json won't work:

{
    "label": "typecheck",
    "type": "shell",
    "command": "npx tsc --noEmit",
    "problemMatcher": {
        "base": "$tsc-watch",
        "fileLocation": ["relative"]
    }
}

Have you found a workaround @segevfiner ? I can't find a problemMatcher.pattern that works for the tsc output

[huzaifahj]

Workaround:

{
  "problemMatcher": {
    "pattern": {
      "regexp": "^([^\\s].*)[\\(:](\\d+)[,:](\\d+)(?:\\):\\s+|\\s+-\\s+)(error|warning|info)\\s+TS(\\d+)\\s*:\\s*(.*)$",
      "file": 1,
      "line": 2,
      "column": 3,
      "severity": 4,
      "code": 5,
      "message": 6
    }
  }
}

[segevfiner]

You also need the background patterns if you are using watch and isBackground. The originals are defined here https://github.com/microsoft/vscode/blob/a3a7f52f7ce697b3e6167cbdc47741d80f7b0867/extensions/typescript-language-features/package.json#L1396. This extension can contribute them by itself under a different name (e.g. "volar-tsc") or if possible and supported by VS Code, using the same name. I don't know what's the behavior when multiple extensions contribute the same problem matchers with the same name.

[huzaifahj]

I'm still getting this error:

Unrecognized problem matcher. Is the extension that contributes this problem matcher installed?

[joezimjs]

It looks like you STARTED to what needed to be done, but you were getting a "the pattern with the identifier $tsc doesn't exist" because you needed to also add the tsc problem pattern.

Here's a link to the original code from the TypeScript Language Features extension: https://github.com/microsoft/vscode/blob/main/extensions/typescript-language-features/package.json#LL1494C1-L1540C7

I highlighted everything you need to copy. Like I said, you previously grabbed the problemMatchers portion, but you missed the problemPatterns portion.