Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

pug slot shorthand highlighting #1423

Closed
Shinigami92 opened this issue Jun 8, 2022 · 6 comments
Closed

pug slot shorthand highlighting #1423

Shinigami92 opened this issue Jun 8, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@Shinigami92
Copy link
Collaborator

This is really a minor not-breaking-anything bug! 馃檪
The # in front of slots are not highlighted in correctly, when it doesn't use an = sign after the slot.

@johnsoncodehk johnsoncodehk added the bug Something isn't working label Jun 8, 2022
@johnsoncodehk johnsoncodehk reopened this Jun 12, 2022
@johnsoncodehk johnsoncodehk reopened this Jul 17, 2022
@Shinigami92
Copy link
Collaborator Author

Back from vacation and updated vue-tsc
Result:
image

Works fine 馃檶 馃挌

@Shinigami92
Copy link
Collaborator Author

@johnsoncodehk
馃 Mh... but I now see that the 2 and the ! is coloured differently
If you like to, you can also try to fix that

@johnsoncodehk
Copy link
Member

@Shinigami92 could you paste the code?

@Shinigami92
Copy link
Collaborator Author

@Shinigami92 could you paste the code?

@johnsoncodehk send full file via Discord direct message

@johnsoncodehk
Copy link
Member

johnsoncodehk commented Sep 25, 2022

@Shinigami92 I can't reproduce, but I guess the problem is caused by another theme extension you have installed.
铻㈠箷鎴湒 2022-09-26 03 44 50

@Shinigami92
Copy link
Collaborator Author

Shinigami92 commented Sep 26, 2022

image

I'm using Dark+ (default dark)

As you can see, the Quasar Components have nice extra colors (that's good) but the exclamation mark in front of scope has the same color as scope
But I switched temporarily to e.g. monokai and there the exclamation mark has another color than the scope

image

Also note that my screenshot is taken with vue-tsc / volar v0.40.1 as I cannot update to the latest and also cannot use/test the preview v1 version right now
I need to wait until it is in stable extension branch to test it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants