- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.37.6 breaks event payload type detection (npm monorepo) #1445
Comments
This is expected, because volar do not have any console.log if it's running normally.
Could you provide minimal reproduction? (Btw I suggest you use takeover mode instead shims) |
@johnsoncodehk we have takeovermode enabled. working on creating a minimal reproduction now |
@johnsoncodehk here's a minimal reproduction. (in takeovermode) and on zip without
|
@johnsoncodehk what is this dark magic fix? 😂 it's just a variable rename? What was wrong? 🤔 |
@mesqueeb Variable rename obfuscate the fix 😅, it should be (fileName is const fileExists = !!host.fileExists?.(fileNameTrim);
if (fileExists) {
// create virtual files
- const scriptSnapshot = host.getScriptSnapshot(fileName);
+ const scriptSnapshot = host.getScriptSnapshot(fileNameTrim);
if (scriptSnapshot) {
- documentRegistry.set(fileName, createSourceFile(
- fileName,
+ documentRegistry.set(fileNameTrim, createSourceFile(
+ fileNameTrim,
scriptSnapshot.getText(0, scriptSnapshot.getLength()),
compilerOptions,
vueCompilerOptions, |
Some oddities
output
list, but it's definitely runningshims
file instead of to the component0.37.3
everything works as expectedThe text was updated successfully, but these errors were encountered: