Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: css classes parsing #1485

Merged
merged 4 commits into from Jun 26, 2022
Merged

fix: css classes parsing #1485

merged 4 commits into from Jun 26, 2022

Conversation

lucas-labs
Copy link
Contributor

Closes #1481

Fixes an issue when parsing css classes when css contains "." character that are not class selectors (example 1.5em or when using scss modules syntax).

+ fixes an issue when parsing css classes when
  css contains "." character that are not class
  selectors (example `1.5em` or when using scss
  modules syntax)
@lucas-labs
Copy link
Contributor Author

don't approve workflows just yet please, got some tests failing, so I got to check that out :)

@lucas-labs
Copy link
Contributor Author

@johnsoncodehk ok, i think it looks better now and tests are passing 😁

image

@johnsoncodehk
Copy link
Member

LGTM, thank you for your works!

@johnsoncodehk johnsoncodehk merged commit 753a800 into vuejs:master Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Css references on properties when using scss functions
2 participants