fix: wrong check for whether jsx option is set #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsoncodehk
force-pushed
the
master
branch
2 times, most recently
from
9301fe2
to
960fab5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old logic
(compilerOptions.jsx ?? ts.JsxEmit.Preserve) !== ts.JsxEmit.Preservedidn't seem right in case thecompilerOptions.jsxwas not set as then it assumed that the default value ispreserveand thus that the resolved value is alsopreserve. That would result in no diagnostic from https://github.com/johnsoncodehk/volar/blob/a77cc83c9f6ac0ff4fdab9989fa9eceadc844a86/packages/vue-language-service/src/plugins/vue.ts#L152-L165 being created.Maybe this had to do with a change in 4e6f6f7 where the real, evaluated options were checked? Not sure.