Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surrounding pairs missing backticks #1659

Closed
movy opened this issue Aug 1, 2022 · 2 comments
Closed

Surrounding pairs missing backticks #1659

movy opened this issue Aug 1, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@movy
Copy link

movy commented Aug 1, 2022

I believe backticks should be surrounding, at least this how it works (and expected to work) in normal JS files. Volar disables this however, I believe must be added here:
https://github.com/johnsoncodehk/volar/blob/4963cd1350431e4bc3734486e56c6f6e877ce8f9/extensions/vscode-vue-language-features/languages/vue-language-configuration.json#L74

@johnsoncodehk
Copy link
Member

For <script> block, vscode use JS surroundingPairs config from https://github.com/microsoft/vscode/blob/b5a1bb34e9c6b77c2a8ccf54bcdbb4bac4d420cb/extensions/javascript/javascript-language-configuration.json#L72, so it do not need to define in vue language config.

@johnsoncodehk johnsoncodehk added question Further information is requested and removed pending triage labels Aug 27, 2022
@movy
Copy link
Author

movy commented Aug 27, 2022

Thanks for following up,
I apologize for not being more verbose in my initial issue description:
Whenever I select a string inside JS <script> in a .vue file and try to surround it with backticks by typing a backtick, the whole selected string gets replaced with a single backtick. This is not how it works with all other surrounding symbols ({} () '' "" etc), hence my guess about the wrong surroundingPairs config.

This is still happening and would be nice to find out why.

Screen.Recording.2022-08-27.at.22.32.11.mov

@johnsoncodehk johnsoncodehk reopened this Aug 27, 2022
@johnsoncodehk johnsoncodehk added enhancement New feature or request and removed question Further information is requested labels Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants