Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniquely scope attribute shorthands #1812

Closed
roydukkey opened this issue Sep 3, 2022 · 2 comments · Fixed by #1830
Closed

Uniquely scope attribute shorthands #1812

roydukkey opened this issue Sep 3, 2022 · 2 comments · Fixed by #1830
Labels
enhancement New feature or request

Comments

@roydukkey
Copy link
Contributor

roydukkey commented Sep 3, 2022 •
edited

As a theme developer, I would like the shorthands for v-bind, v-on, v-slot to be uniquely scoped so they can be targeted in themes.

I proposed that we replace the punctuation.separator.key-value.html.vue scope from each of the following shorthands with...

  1. punctuation.attribute-shorthand.bind.html.vue for :
  2. punctuation.attribute-shorthand.event.html.vue for @
  3. punctuation.attribute-shorthand.slot.html.vue for #

Let me know if you'll accept a PR.
@johnsoncodehk
Copy link
Member

Of course, PR is welcome!

@johnsoncodehk johnsoncodehk added the enhancement New feature or request label Sep 4, 2022
@roydukkey roydukkey mentioned this issue Sep 6, 2022
Merged
@roydukkey
Copy link
Contributor Author

Closes by #1830

@johnsoncodehk johnsoncodehk linked a pull request Sep 6, 2022 that will close this issue
feat: uniquely scope attribute shorthands #1830
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: uniquely scope attribute shorthands
2 participants
@roydukkey @johnsoncodehk