Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check workspaceFolders capability before registering onDidChangeWorkspaceFolders handler #1834

Merged

Conversation

tsukkee
Copy link
Contributor

@tsukkee tsukkee commented Sep 7, 2022

When volar is used with LSP clients which doesn't support workspaceFolders, the exception from the following part is raised.

https://github.com/microsoft/vscode-languageserver-node/blob/5c2e1065493290110bd7c7ea1b10cd6fa08eb81c/server/src/common/workspaceFolder.ts#L48-L50

So, I add code to check workspaceFolders capability also before registering onDidChangeWorkspaceFolders handler.

@johnsoncodehk johnsoncodehk merged commit 0ef9fa2 into vuejs:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants