Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Custom file extensions other than .vue #1931

Closed
cabal95 opened this issue Oct 5, 2022 · 3 comments
Closed

Feature: Custom file extensions other than .vue #1931

cabal95 opened this issue Oct 5, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@cabal95
Copy link
Contributor

cabal95 commented Oct 5, 2022

We are looking to be able to use custom file extensions with Vue to differentiate some of our components between other components we have. Our compiler chain works fine with custom file extensions other than .vue, but the Volar extension has a few places where this is hard coded. I did a quick test and dropped in our custom extensions in a couple places and everything seems to work.

Would you be open to a pull request that adds a new configuration setting that would pass along these custom file extensions to the underlying services?

This would just be to make Volar's internals treat these other file extensions the same as if they were .vue. It would not automatically add file associations (unless I can find a way to do that dynamically instead of in package.json) - but VS Code already has support for that.

@johnsoncodehk
Copy link
Member

Please feel free to open a PR. :) (If you don't mind I will modify it directly.)

@johnsoncodehk johnsoncodehk added the enhancement New feature or request label Oct 5, 2022
@cabal95
Copy link
Contributor Author

cabal95 commented Oct 5, 2022

Okay great, I'll work on that!

@cabal95
Copy link
Contributor Author

cabal95 commented Oct 21, 2022

Implemented by #2035

@cabal95 cabal95 closed this as completed Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants