Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace Math.pow with (<<) for base 2 #2056

Merged
merged 2 commits into from Oct 24, 2022

Conversation

Fuzzyma
Copy link
Contributor

@Fuzzyma Fuzzyma commented Oct 24, 2022

The PR of this tweet:

https://twitter.com/johnsoncodehk/status/1584181852595974144

I replaced Math.pow with left shifts because they are substantially faster

@Fuzzyma
Copy link
Contributor Author

Fuzzyma commented Oct 24, 2022

Alright it seems like you were faster :D

@Fuzzyma Fuzzyma closed this Oct 24, 2022
@johnsoncodehk
Copy link
Member

That is correct but you're late. 😝
Duplicate of #2053

@johnsoncodehk johnsoncodehk reopened this Oct 24, 2022
@johnsoncodehk johnsoncodehk merged commit 73a25cc into vuejs:master Oct 24, 2022
@Fuzzyma
Copy link
Contributor Author

Fuzzyma commented Oct 24, 2022

oh thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants