Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detection of slots in script-less SFC #2113

Merged

Conversation

elevatebart
Copy link
Contributor

@elevatebart elevatebart commented Nov 13, 2022

Hello @johnsoncodehk,

I finally found what was missing in the detection of slots.
If a Single File Component does not have a script block the slots are entirely ignored, not detected by cue-component-meta.
Same goes if a component does not use the <script setup> syntax.

I added the test here.

@elevatebart elevatebart changed the title test: add failing test for desired feature fix: detect of slot sin script-less SFC Nov 13, 2022
@elevatebart elevatebart changed the title fix: detect of slot sin script-less SFC fix: detection of slots in script-less SFC Nov 25, 2022
@johnsoncodehk johnsoncodehk marked this pull request as ready for review January 5, 2023 07:50
@johnsoncodehk johnsoncodehk merged commit b6dac62 into vuejs:master Jan 5, 2023
@elevatebart elevatebart deleted the elevatebart/slot-without-script branch January 5, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants