Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add volar.virtualFiles.mappingSelectionBackgroundColor setting #2170

Merged
merged 3 commits into from Dec 8, 2022

Conversation

Sight-wcg
Copy link
Contributor

close #2147

default

  • dark
    ddark
  • light
    dlight

configured by string

"volar.virtualFiles.mappingSelectionBackgroundColor":  "#F8C9AB"
  • light
    strlight

configured by theme

// https://code.visualstudio.com/api/references/theme-color#editor-colors
"volar.virtualFiles.mappingSelectionBackgroundColor": {
  "id": "editor.selectionBackground"
},
  • dark
    主题dark

  • light
    主题light

@Sight-wcg Sight-wcg changed the title feat: add volar.virtualFiles.mappingSelectionBackgroundColor setting feat: add volar.virtualFiles.mappingSelectionBackgroundColor setting Dec 4, 2022
@johnsoncodehk
Copy link
Member

LGTM, thanks!

The setting is not needed because you already add the light background color.

@johnsoncodehk johnsoncodehk merged commit 250cc4b into vuejs:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volar (Debug): Show Virtual Files uses hard-coded color with poor contrast
2 participants