Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add an indicator to show we're on takeover mode #2365

Closed
rodrigocfd opened this issue Feb 7, 2023 · 5 comments
Closed

Feature request: add an indicator to show we're on takeover mode #2365

rodrigocfd opened this issue Feb 7, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@rodrigocfd
Copy link

When used with VSCode, Volar may use takover mode to improve performance, but there's no way to know whether it's active or not. One must redo all the steps in order to check it.

It would be helpful to have, in the status bar, an indicator showing we're currently on takeover mode.

@yusufkandemir
Copy link
Contributor

Takeover mode OFF:
image

Takeover mode ON:
image

Along with other stuff, (vue) should be enough to understand that it's active. If you click that, you will be presented with this dialog:
image
Which also gives a hint about the takeover mode.

@rodrigocfd
Copy link
Author

So when packages/client/tsconfig.json is present, it means takeover mode is active? I really don't think this is a good indication at all.

I'd expect to see something like Takeover: on. That would be clear.

@yusufkandemir
Copy link
Contributor

That was not what I meant, the version number and (vue) after that is the main point. Personally, the version number and (vue) is enough, but (takeover)/(vue/takeover) could also be a more verbose option.

@johnsoncodehk
Copy link
Member

@yusufkandemir's suggestion is correct, please note that you should be opening .ts not .vue files to judge it.

On the other hand, more explicit prompts can also be considered. In fact, the old version used to display (takeover) in the status bar, which was simplified to (vue) in order to reduce the space occupied by the status bar.

@johnsoncodehk johnsoncodehk added the enhancement New feature or request label Feb 8, 2023
@rodrigocfd
Copy link
Author

The problem with displaying (vue) is that it's in the same place we see the type of the file currently open, like Markdown or Plain text. So, when I see (vue) down there, I just thought "it's a Vue file".

markdown-status

Plus, we have vue and (vue) in the status bar... which is which?

vue-twice

That's why I believe having Takeover: on and Takeover: off would be way more clear.

But I understand the concern for the used space, so maybe we could have (TO) instead of (vue), which is even shorter. Then, when hovering with the mouse, a tooltip could say "You're using Volar in takeover mode".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants