Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@click ,no code prompt #2661

Closed
DZHAPPY opened this issue Apr 21, 2023 · 6 comments
Closed

@click ,no code prompt #2661

DZHAPPY opened this issue Apr 21, 2023 · 6 comments

Comments

@DZHAPPY
Copy link

DZHAPPY commented Apr 21, 2023

When using versions 1.4.0 to 1.4.2 to enter @, there will be no prompt for shortcut codes such as @ click, and using 1.2.0 does not have this issue

@roydukkey
Copy link
Contributor

I'm hitting a similar issue today after updating from 1.2.0 to newer. The issue seems that vscode extension is not resolving template types correctly.

1.2.0 (working)

v1.2.0.mov

1.4.2 (not working)

v1.4.2.mov

I also have a vsc-tsc script checking types during build. vsc-tsc it continue to work properly in the templates.

@johnsoncodehk
Copy link
Member

Can you reproduce this problem in https://github.com/johnsoncodehk/volar-starter?

@roydukkey
Copy link
Contributor

No, actually. I tried with this repo, and the only difference is that I tried this on a different computer.

@johnsoncodehk
Copy link
Member

Can you provide repro case?

@roydukkey
Copy link
Contributor

roydukkey commented Apr 22, 2023

Okay. Here are some more diagnostic info.

Attempt 1
1. Using the same machine that originally had the issue
2. Updated Vue.volar VSCode extension to v1.4.3
3. Rebuild my mono repo. Still have issue.

Attempt 2
1. Continuing from where "Attempt 1" ended.
1. Update macOS from Ventura 13.2 to 13.3.1
2. Rebuild my mono repo. Issue is fixed.

VScode Info
Version: 1.77.3 (Universal)
Commit: 704ed70d4fd1c6bd6342c436f1ede30d1cff4710
Date: 2023-04-12T09:19:37.325Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: 10.2.154.26-electron.0
OS: Darwin arm64 22.4.0
Sandboxed: No

Computer Info
MacBook Pro
Chip: Apple M1 Pro

My mono repo is private so I cannot share a reproduction, and I'm not able to give time and attention to downgrading my macOS version to see if the issue returns. If there is anything else I can do to help, let me know.

@DZHAPPY I'm curious if any of this lines up with your experience. Do other items in your templates have any types like I show in my video? How about your OS version?

Edit: striked this through because it is not even close to being accurate.

@roydukkey
Copy link
Contributor

Okay. I've been able to lock this down to a reproduction. It turns out my brain on the weekend is lazy sometimes, because my previous comment is not accurate at all. 😅

https://github.com/roydukkey/moist/tree/vuejs/language-tools%232661

There are several commits on this branch that show the progression through the issue and the README has more videos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants