Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating volar from 1.2 to 1.4 breaks prop typing for events #2700

Closed
Fuzzyma opened this issue Apr 24, 2023 · 1 comment
Closed

Updating volar from 1.2 to 1.4 breaks prop typing for events #2700

Fuzzyma opened this issue Apr 24, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@Fuzzyma
Copy link
Contributor

Fuzzyma commented Apr 24, 2023

Since using v 1.4 of volar, I get strange errors on event handlers that might be undefined:

grafik
grafik

grafik
grafik

The handling function might be undefined and that seems to be a problem all of a sudden.
Before, undefined as event handler would just not bind to that event.

I think this error is triggered when declaring props instead of events (e.g. onCancel prop vs cancel emit).
But it also happens for the transition component so I am not entirely sure

@johnsoncodehk johnsoncodehk added the bug Something isn't working label Apr 24, 2023
@johnsoncodehk
Copy link
Member

johnsoncodehk commented Apr 24, 2023

Transition @after-leave type not work as well even in v1.2.0, which shows unknown in v1.2.0, but it should be Hook<(el: Element) => void>. Fixed in 09fbbb7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants