Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax colorating and typings stops working since 1.6.0 #2742

Closed
vidal7 opened this issue Apr 27, 2023 · 9 comments
Closed

Syntax colorating and typings stops working since 1.6.0 #2742

vidal7 opened this issue Apr 27, 2023 · 9 comments
Labels
bug Something isn't working good reproduction ✨ This issue provides a good reproduction, we will be able to investigate it first

Comments

@vidal7
Copy link

vidal7 commented Apr 27, 2023

Hello. I have this problem since version 1.6.0. I have no more syntax coloring in vscode and typescript type of component seems to be of type any.
image

In version 1.4.4, everything was working fine
image

@johnsoncodehk
Copy link
Member

I can't reproduce this problem, please provide minimal reproduction.

@WAJoakimB
Copy link

Same issue. Prop types are shown as any when hovering over them. Also not getting all Vue warnings/errors in Visual Code, e.g. when a required prop is missing for a child component. No problem in 1.4.4.

@vidal7
Copy link
Author

vidal7 commented Apr 27, 2023

@johnsoncodehk, here is a minimal reproduction repo https://github.com/vidal7/volar-issue-2742.

There is no syntax coloring in component app.vue since 1.6.0. 1.4.4 is working fine.

@johnsoncodehk
Copy link
Member

johnsoncodehk commented Apr 27, 2023

Thanks for the reproduction, but I still can't see the problem, I tried in local env and GitHub Codespaces.

image

What is your VSCode version? Have you try clean node_modules and re-install?

@xzhangi
Copy link

xzhangi commented Apr 27, 2023

I have the same issue, and tried downgrading version by version. Apparently the issue does not exist in 1.5.2 and only started appearing in 1.5.3 onwards

VSCode version - 1.76.2

@johnsoncodehk
Copy link
Member

I reproduced it and this happens when using TS 4.8.

@johnsoncodehk johnsoncodehk added bug Something isn't working good reproduction ✨ This issue provides a good reproduction, we will be able to investigate it first and removed need info labels Apr 27, 2023
@mdoesburg
Copy link

Same issue with TS 4.7.4.

@vidal7
Copy link
Author

vidal7 commented Apr 27, 2023

@johnsoncodehk you are right.

TS 4.8.3 is not working
TS 4.9.5 is not working
TS 5.0.4 is working

I am using typescript workspace version so I can switch typescript version without changing vscode versions.

@vidal7
Copy link
Author

vidal7 commented Apr 27, 2023

Wow! You are a super human @johnsoncodehk. Thank you for fixing it so fast!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good reproduction ✨ This issue provides a good reproduction, we will be able to investigate it first
Projects
None yet
Development

No branches or pull requests

5 participants