Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support inlay hints #452

Closed
wants to merge 3 commits into from
Closed

feat: support inlay hints #452

wants to merge 3 commits into from

Conversation

johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented Sep 3, 2021

LSP Issue: microsoft/language-server-protocol#956
Document: https://code.visualstudio.com/updates/v1_60#_inlay-hints-for-javascript-and-typescript

This feature still in VSCode Proposed API, LSP don't support yet, currently implement by VSCode client API, and only able to test in VSCode Insider.

Setup:

  1. Launch VSCode Insider (1.60 later) by command code-insiders . --enable-proposed-api johnsoncodehk.volar.
  2. Install volar-0.27.13-inlay-hints.2.vsix.zip to VSCode Insider. (You can bulit it youself by npm run pack command)
  3. Search inlayHints in VSCode settings and enable features your needs.

Reference: https://code.visualstudio.com/api/advanced-topics/using-proposed-api#sharing-extensions-using-the-proposed-api

@johnsoncodehk johnsoncodehk marked this pull request as draft September 3, 2021 16:41
@Kingwl
Copy link
Member

Kingwl commented Oct 9, 2021

Looks good.

@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Oct 28, 2021
@oxk4r01
Copy link

oxk4r01 commented Oct 29, 2021

Ok, done. But there are some issues:
When the editor is splitted vertically or horizontally hints dissapear,
Same if I update the extension to v0.28.

@johnsoncodehk
Copy link
Member Author

@oxk4r01 This PR is implement in 0.27.13, how do you update to 0.28?

@oxk4r01
Copy link

oxk4r01 commented Oct 30, 2021

VSCode downloaded automatically v0.28. I had to disable auto updating for the extension.

@johnsoncodehk
Copy link
Member Author

@oxk4r01 This feature is not available in the automatically updated version, because vscode does not allow release experimental features, please wait for this feature to leave experimental on vscode.

@oxk4r01
Copy link

oxk4r01 commented Oct 30, 2021

Then maybe it changed the version due to the sync settings config. I have v0.28 in another computer. I don't know.

@Shinigami92
Copy link
Collaborator

Would you like to give this a new try? 😃

@johnsoncodehk
Copy link
Member Author

Would you like to give this a new try? 😃

Can't implement yet, still have to wait to out of proposed in vscode.

@johnsoncodehk johnsoncodehk deleted the Inlay-hints branch April 18, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants