Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not compile #12

Open
montogeek opened this issue Jun 14, 2015 · 7 comments
Open

Does not compile #12

montogeek opened this issue Jun 14, 2015 · 7 comments

Comments

@montogeek
Copy link

Hi, the current version of the package can not be used, there is an error compiling:

Error: Cannot find module 'ie' from '/project/node_modules/superagent-no-cache']
  stream:
   { _readableState:
      { highWaterMark: 16,
        buffer: [],
        length: 0,
        pipes: [Object],
        pipesCount: 1,
        flowing: true,
        ended: false,
        endEmitted: false,
        reading: true,
        sync: false,
        needReadable: true,
        emittedReadable: false,
        readableListening: false,
        objectMode: true,
        defaultEncoding: 'utf8',
        ranOut: false,
        awaitDrain: 0,
        readingMore: false,
        decoder: null,
        encoding: null,
        resumeScheduled: false },
     readable: true,
     domain: null,
     _events:
      { end: [Object],
        error: [Object],
        data: [Function: ondata],
        _mutate: [Object] },
     _maxListeners: undefined,
     _writableState:
      { highWaterMark: 16,
        objectMode: true,
        needDrain: false,
        ending: true,
        ended: true,
        finished: true,
        decodeStrings: true,
        defaultEncoding: 'utf8',
        length: 0,
        writing: false,
        corked: 0,
        sync: false,
        bufferProcessing: false,
        onwrite: [Function],
        writecb: null,
        writelen: 0,
        buffer: [],
        pendingcb: 0,
        prefinished: true,
        errorEmitted: false },
     writable: true,
     allowHalfOpen: true,
     _options: { objectMode: true },
     _wrapOptions: { objectMode: true },
     _streams: [ [Object] ],
     length: 1,
     label: 'deps' } }

Using these versions of NPM and Node
npm --version 2.5.1
node --version v0.12.1

I am using browserify v 10.2.0

Looks like the exception on index.js are not caught.

@RichieAHB
Copy link

+1

npm --v 2.7.3
node --version v0.12

@therebelrobot therebelrobot self-assigned this Sep 1, 2015
@uditalias
Copy link

This happens because the author supports NPM and COMPONENT package managers, when installing with component, the module called ie and when installing from npm the module called component-ie, looks like error throwing from require cannot be cached in a try/catch statement so I made a fork to support only npm at https://github.com/uditalias/superagent-no-cache, you can update your package.json file to install it directly from there:

  "dependencies": {
        "superagent-no-cache": "uditalias/superagent-no-cache"
   }

@therebelrobot
Copy link
Collaborator

This was a relatively recent change, specifically when NPM support was added (#3). I can take a look into it later tonight, see what I can do to resolve it.

@mharrisweb
Copy link

+2

Using node 0.12.1, npm 2.5.1

@therebelrobot
Copy link
Collaborator

@johntron I no longer have the bandwidth to maintain this lib. Have you got time to take a look at this?

@johntron
Copy link
Owner

Is this still an issue with 0.1.1?

@johntron
Copy link
Owner

@montogeek @RichieAHB @mharrisweb – I know it's been years, but addressed the IE issue here: #23. If you still care, please let me know if you see any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants