Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow limit without pagination on sqlite3 or mysql #243

Open
mitjade opened this issue Sep 28, 2017 · 3 comments · May be fixed by #535
Open

Allow limit without pagination on sqlite3 or mysql #243

mitjade opened this issue Sep 28, 2017 · 3 comments · May be fixed by #535
Assignees

Comments

@mitjade
Copy link

mitjade commented Sep 28, 2017

I would like to use join-monster with sqlite3 or mysql database, but it prevents me setting the limit.

You state in the docs, that limit can only be used if pagination is supported for your SQL dialect. But I do not see why not allowing the use of limit with sqlite3 or mysql if you want to use it without pagination?

@mitjade
Copy link
Author

mitjade commented Nov 20, 2017

Created a PR #264, that would allow this.

Please comment if this would be acceptable, or some other changes are needed.

@iAlirezaKML
Copy link

I think changing await to yield solves the Test failed problem.

@mposborne
Copy link

Rather than modify code functions i've been able to setup a new MySQL dialect to do just this. I'm sure sqlite3 will be similar.

This is setup for full pagination so you can provide an offset if you want, but it is optional.

https://github.com/RollHQ/join-monster-mysql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants