-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple type of joins. #287
Comments
My thoughts on alternative JOINs:
Maybe you can just give some examples where it would be useful to work with other JOINs. |
I too would like to see at least INNER JOIN available. Sometimes we do not want the parent to be available if there are no children. |
Still.. Is there any possibility for inner join in join monster? |
Hello.... |
@upasanadash I think you can fork and edit it yourself then have your own version to use for temporary if it's urgent. |
I think the case where you need an inner join most is for specifying conditions. E.g. consider the following query from Hasura that fetches authors who have an article with a rating greater than four stars. I don't think you could do that without an inner join.
What would the approach be to do this in Join Monster? You could fetch all articles with ratings greater than four stars first, but that would be wasteful and potentially prohibitive. |
I am just starting to prototype a bit with this library and the first thing I notice is that it's using LEFT JOINs everywhere. I did take a look in the code and there's no support whatsoever for any other type than that. (hardcoded)
Is there a plan for support an INNER, RIGHT, FULL or CROSS (OUTER/LATERAL) join?
I understand that it's more taxing on the config side when defining your schema, but using a LEFT join for everything is not really efficient in most cases. I think that a preliminary support for an INNER join can be achieved with purely the type of the field that has the sqlJoin (GraphQLList vs a non list.)
The text was updated successfully, but these errors were encountered: