Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve soft-delete filtering on m2os #807

Open
stephenh opened this issue Sep 27, 2023 · 0 comments
Open

Improve soft-delete filtering on m2os #807

stephenh opened this issue Sep 27, 2023 · 0 comments
Labels
enhancement New feature or request hack day seems doable in a hack day

Comments

@stephenh
Copy link
Collaborator

Currently our m2os do not filter out soft-deleted entities with the rationale that, for required columns, it would change the return type from Book to Book | undefined.

However, for optional FKs, like ProjectItem.task in our domain, it's more okay to return undefined, b/c the type is already M2O<Task | undefined>.

Although maybe we should also consider it being invalid for a non-SD entity to point to a SD entity in the first place, and require the PI.task reference to be cleared in the db.

See Internal slack thread

@stephenh stephenh added enhancement New feature or request hack day seems doable in a hack day labels Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hack day seems doable in a hack day
Projects
None yet
Development

No branches or pull requests

1 participant