Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce soft-deleted entities are unhooked #910

Open
stephenh opened this issue Dec 12, 2023 · 0 comments
Open

Enforce soft-deleted entities are unhooked #910

stephenh opened this issue Dec 12, 2023 · 0 comments

Comments

@stephenh
Copy link
Collaborator

stephenh commented Dec 12, 2023

And in general ergonomics like:

  • A `onSoftDeleteCascade("children") for a soft-deleted to soft-delete its owned children
  • A `onSoftDeleteUnset("projectItem") for a soft-deleted entity to unhook itself from other entities

Examples

Cascade to soft-deleted children & on soft-delete cascade a hard deletion to other children:

/** Cascade cascade soft deletes to dependencies. */
// TODO(soft-deleted): https://github.com/stephenh/joist-ts/issues/910
config.beforeFlush(["requiredTaskDocuments", "scheduleTaskChecklistItems"], async (task, { em }) => {
  if (task.isSoftDeletedEntity && task.changes.deletedAt.hasChanged) {
    const dependencies = (
      await Promise.all([task.successorDependencies.load(), task.predecessorDependencies.load()])
    ).flat();
    dependencies.forEach((d) => d.softDelete());
    task.requiredTaskDocuments.get.forEach((rtd) => em.delete(rtd));
    task.scheduleTaskChecklistItems.get.forEach((stci) => em.delete(stci));
  }
});
/** On task soft-delete, unhook any project items. */
// TODO(soft-deleted): https://github.com/stephenh/joist-ts/issues/910
config.beforeFlush(async (task) => {
  if (task.isSoftDeletedEntity) {
    const projectItems = await task.load((t) => t.projectItems);
    projectItems.forEach((pi) => pi.task.set(undefined));
  }
});

Maybe prevent soft deletion?

/** Tasks on a draw schedule, or a global milestone, cannot be soft-deleted. */
config.addRule(async (task) => {
  if (task.isSoftDeletedEntity) {
    const draws = await task.load((t) => t.homeownerContractDraws);
    if (draws.length > 0) {
      return "Cannot delete tasks on a draw schedule";
    }
    if (!task.allowMilestoneDelete && (await task.isGlobalMilestoneTask())) {
      return "Milestone tasks cannot be deleted";
    }
  }
});
@stephenh stephenh changed the title Enforce soft-deleted entities being hooked Enforce soft-deleted entities are unhooked Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant