From f0750cce8a25467db92c9d760591f4902b44b7b3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Pineau?= Date: Fri, 15 Mar 2024 13:44:37 +0100 Subject: [PATCH 1/3] ci: update some actions version --- .github/workflows/ci.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index e083570..ab7249b 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -13,7 +13,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: PHP-CS-Fixer uses: docker://oskarstark/php-cs-fixer-ga @@ -35,7 +35,7 @@ jobs: name: '(prefer lowest dependencies)' steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Setup PHP, with composer and extensions uses: shivammathur/setup-php@v2 From f39b6eaef75203c88ec1236dad947f0a3b49d28c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Pineau?= Date: Fri, 15 Mar 2024 13:44:50 +0100 Subject: [PATCH 2/3] ci: format yaml --- .github/workflows/ci.yaml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index ab7249b..7dd0820 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -2,10 +2,10 @@ name: CI on: push: - branches: [ main ] + branches: [main] pull_request: schedule: - - cron: '0 0 * * MON' + - cron: "0 0 * * MON" jobs: check-cs: @@ -18,7 +18,7 @@ jobs: - name: PHP-CS-Fixer uses: docker://oskarstark/php-cs-fixer-ga with: - args: --config=.php-cs-fixer.php --diff --dry-run + args: --config=.php-cs-fixer.php --diff --dry-run ci: name: Test PHP ${{ matrix.php-version }} ${{ matrix.name }} @@ -26,13 +26,13 @@ jobs: strategy: fail-fast: false matrix: - php-version: ['8.2', '8.3'] - composer-flags: [''] - name: [''] + php-version: ["8.2", "8.3"] + composer-flags: [""] + name: [""] include: - php-version: 8.1 - composer-flags: '--prefer-lowest' - name: '(prefer lowest dependencies)' + composer-flags: "--prefer-lowest" + name: "(prefer lowest dependencies)" steps: - name: Checkout uses: actions/checkout@v4 From d4051b9ed522b2160663b60b607b157159aa17af Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Pineau?= Date: Fri, 15 Mar 2024 13:49:19 +0100 Subject: [PATCH 3/3] chore: fixed CS --- src/Exception/Exception.php | 4 +++- src/Exception/InvalidNotificationException.php | 2 +- src/Exception/NoSupportedNotifierException.php | 2 +- src/Util/OsHelper.php | 4 +++- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/Exception/Exception.php b/src/Exception/Exception.php index d3ea6b4..4f20721 100644 --- a/src/Exception/Exception.php +++ b/src/Exception/Exception.php @@ -11,4 +11,6 @@ namespace Joli\JoliNotif\Exception; -interface Exception {} +interface Exception +{ +} diff --git a/src/Exception/InvalidNotificationException.php b/src/Exception/InvalidNotificationException.php index 6c4313a..d4a4922 100644 --- a/src/Exception/InvalidNotificationException.php +++ b/src/Exception/InvalidNotificationException.php @@ -21,7 +21,7 @@ public function __construct( Notification $notification, $message = '', $code = 0, - Exception $previous = null + ?Exception $previous = null ) { $this->notification = $notification; diff --git a/src/Exception/NoSupportedNotifierException.php b/src/Exception/NoSupportedNotifierException.php index d341562..a0f0599 100644 --- a/src/Exception/NoSupportedNotifierException.php +++ b/src/Exception/NoSupportedNotifierException.php @@ -16,7 +16,7 @@ class NoSupportedNotifierException extends \RuntimeException implements Exceptio public function __construct( $message = 'No supported notifier', $code = 0, - Exception $previous = null + ?Exception $previous = null ) { parent::__construct($message, $code, $previous); } diff --git a/src/Util/OsHelper.php b/src/Util/OsHelper.php index 471f4ce..75fbed5 100644 --- a/src/Util/OsHelper.php +++ b/src/Util/OsHelper.php @@ -16,4 +16,6 @@ /** * @deprecated since 2.6, use OsHelper from jolicode/php-os-helper instead */ -class OsHelper extends BaseOsHelper {} +class OsHelper extends BaseOsHelper +{ +}