Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to force the refresh on the Indexer bulk request #31

Open
damienalexandre opened this issue Jul 6, 2020 · 1 comment
Open

Add a way to force the refresh on the Indexer bulk request #31

damienalexandre opened this issue Jul 6, 2020 · 1 comment
Assignees
@damienalexandre
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest

Comments

@damienalexandre
Copy link
Member

damienalexandre commented Jul 6, 2020 •
edited

Being able to set $bulk->setRequestParam('refresh', 'wait_for'); could be useful.

Same goes for pipeline.
@damienalexandre damienalexandre added enhancement New feature or request good first issue Good for newcomers labels Jul 6, 2020
@ThibautSF ThibautSF mentioned this issue Oct 7, 2020
Open
@damienalexandre damienalexandre self-assigned this Oct 15, 2020
@ThibautSF
Copy link

Being able to set $bulk->setRequestParam('refresh', 'wait_for'); could be useful.

Same goes for pipeline.

In fact I would extend to: being able to set any requestParam -> https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-bulk.html#docs-bulk-api-query-params

Very basic implementation idea :
Maybe Indexer->setBulkRequestsParam(string $paramName, $value)
Each value stored in an associative array (like Elastica Bulk->setRequestParam()) and each time getCurrentBulk instantiate a new Bulk object, the array is read to transfer the parameters to the new Bulk

damienalexandre added a commit that referenced this issue Oct 20, 2020
@damienalexandre
Ref #31 Add bulk query string parameters support
c1c6278
@damienalexandre damienalexandre mentioned this issue Oct 20, 2020
Merged
damienalexandre added a commit that referenced this issue Dec 28, 2020
@damienalexandre
Ref #31 Add bulk query string parameters support (#45)
80c711d 
* Ref #31 Add bulk query string parameters support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damienalexandre damienalexandre

Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@damienalexandre @ThibautSF