Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: add DataCollector for elastically #38

Open
gabiudrescu opened this issue Aug 10, 2020 · 4 comments
Open

Improvement: add DataCollector for elastically #38

gabiudrescu opened this issue Aug 10, 2020 · 4 comments
Labels
enhancement New feature or request v2.0 Breaking Change / Feature planned for 2.0

Comments

@gabiudrescu
Copy link

I am noting down feedback as I have started playing around with https://github.com/monsieurbiz/SyliusSearchPlugin

I might be able to contribute, if I end up implementing this in my project, but first, I want to hear your opinion as well.


I would like to have a DataCollector for elastically, similar with what FOS Elastica has.

@damienalexandre
Copy link
Member

Hi,

yes that's something I'd like to have as well.

But it has to add value somehow. For example, just listing the request/responses does not add anything, because when you use the HttpClient for Symfony, you already got the Http Calls panels with all the informations.

@gabiudrescu
Copy link
Author

Hmm, indeed. I opened this after I have tested this https://github.com/monsieurbiz/SyliusSearchPlugin

And I think for some reason, they don't use Symfony Http client.

What would you want to see in a data collector?

@damienalexandre
Copy link
Member

Here is what I can think of:

  • list of all the request of course
  • on each request / reponse:
    • timings
    • JSON formatting / nice readable display
    • a "copy as curl" or "open in Kibana Dev Tools" button
    • an "explain" button?
    • a "profile" button? (displaying the result is hard!)
    • a "replay" button?
  • some informations about the Elastica configuration (connexions etc)
  • some way to detect duplicated requests, adding a warning

That's just what pop's up my head right now but not all of those are worth the time 👍

@tacman
Copy link
Contributor

tacman commented Mar 7, 2021

I would also like to see this, but I'm wondering if this should be part of an ElasticallyBundle, rather than part of the core library.

I think a bundle would also allow some other goodies that FOSElasticaBundle has, like a command line way to populate the database.

@damienalexandre damienalexandre added enhancement New feature or request v2.0 Breaking Change / Feature planned for 2.0 labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.0 Breaking Change / Feature planned for 2.0
Projects
None yet
Development

No branches or pull requests

3 participants