Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocumentExchangerInterface should also allow fetching multiple documents at once #55

Open
damienalexandre opened this issue Feb 8, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers v2.0 Breaking Change / Feature planned for 2.0

Comments

@damienalexandre
Copy link
Member

From a performance POV, the current DocumentExchangerInterface is not ideal for the MultipleIndexationRequest use-case.

It can only fetch one document at a time, so it perform 1 SQL request (if SQL is used) for each IndexationRequest instead of possibly one for the whole MultipleIndexationRequest.

Would be nice to add DocumentExchangerInterface::fetchDocuments and use it when appropriate.

@damienalexandre damienalexandre added enhancement New feature or request good first issue Good for newcomers v2.0 Breaking Change / Feature planned for 2.0 labels Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers v2.0 Breaking Change / Feature planned for 2.0
Projects
None yet
Development

No branches or pull requests

1 participant