Seems to crash Sublime when running 'Project and Open files'

[brainz80]

First off thank you for making this plugin and a petty the development has ended.

Noticed a bug where SublimeTodoReview seems to crash Sublime when I run 'Project and Open files' on a Sublime instance with no open files.

I'm running Sublime 3 build 3126 on Windows 7 64bit.

[ghost]

I'm getting the same issue.

Sublime 3 build 3126 on macOS 10.12.4

[jonathanrdelgado]

Sorry about the non-reply to this, I guess I accidentally dismissed the notification.

To clarify, the entire editor crashes? Is it only when a certain project is scanned? Is there any steps you can recommend so I can reproduce this?

[ghost]

The entire editor crashes. Attaching two screenshots showing scenario in which it works and scenario in which it crashes.

[jonathanrdelgado]

• Is it only occurring when you are right clicking on the tree to search (versus the command palette)?
• Did this just start occurring, or is this your first time using the plugin?
• If this did just start occurring, what has recently changed that could cause this?
• Does this occur 100% of the time, even with empty folders?
• If you have a file open, does it work normally? (this was the original issue)

Sorry for all the questions, but I'm unable to reproduce, and since it crashes the entire editor, it isn't possible to get an error stack trace.

[ghost]

Sorry to change the message, but it does seem that it now crashes irrespective of expanded/collapsed state of folders.

If you have a file open it works normally.

It also occurs with command palette: not if search is open files, but does crash on project files/project and open files. This occurs it seems regardless of the expanded/collapsed state of folders.

To summarise: As long as no file is open in editor, doing a TodoReview from the right hand context menu or command palette causes a crash (for me).

---

Just tried the following:

• close all sublime windows

• open an empty folder

• right click and TodoReview => crash

• close all sublime windows

• open an empty folder

• open a file for editing

• right click and TodoReview => no crash (second file appears in editor showing TodoReview results)

[jonathanrdelgado]

Thank you for the detailed response. I am still unable to replicate on my side, so I assume there is something specific happening on your side. I think we can eliminate OS specific issues since the original issue was with Windows, as well.

I combed over the code, the only two times where I see something dependent upon an open file is when someone is to run "TodoReview: Project and Open Files" (which isn't run when using the sidebar shortcut) and when actual rendering occurs (but that uses a tab the plugin instances itself).

I'm really at a loss of what could possibly be the issue on this one, any recommendations welcome!

[mrmikee]

on Mac 10.12.6 with SublimeText3 build 3126 I can right click any file and ToDoReview works fine, but if I right click any folder it crashes SublimeText editor completely.

I do have the following user settings defined:
{ "patterns": { "TODO": "TODO[\\s]*?:+(?P<todo>.*)$", "FIXME": "FIXME[\\s]*?:+(?P<fixme>.*)$" }, "exclude_folders": [ "*.git*", "static", // "css" ], "exclude_files": [ "*.sublime-workspace", "*.sublime-project" ], "case_sensitive": false, "render_include_folder": false, "render_spaces": 1, "navigation_forward_skip" : 10, "navigation_backward_skip" : 10 }

UPDATE: removing the user settings completely allowed ToDoReview to work without crashing.

UPDATE_2: sorry, as soon as I clicked open a subfolder and ran ToDoReview again it crashed the editor again.

[parto254]

Ubuntu 16.04 with Sublime Text 3 build 3176

I tried it on a projects folder with 103 directories and 654 files - it crashed.
I then added *.lock (composer.lock) into my exclude_files settings and tried again - this time it didn't crash.

Here's my TodoReview user settings file content:

{
    "exclude_files": [
        "*.sublime-workspace",
        "*.sublime-project",
        "*.lock"
    ]
}