Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should also take effect on accessors #25

Closed
kainino0x opened this issue Jun 9, 2021 · 4 comments
Closed

Should also take effect on accessors #25

kainino0x opened this issue Jun 9, 2021 · 4 comments

Comments

@kainino0x
Copy link

This is a really handy plugin, thanks!

I found that while it behaves as expected for methods and fields, it doesn't work on accessors (getters, e.g. get device(), and setters, e.g. set device()); they still show up in child classes.
@jonchardy
Copy link
Owner

jonchardy commented Oct 19, 2021 •
edited

Seems as though TypeDoc's inheritedFrom property on reflections isn't accurate for accessors, at least at the time the declaration is created. I'll look into it.

@jonchardy
Copy link
Owner

Logged TypeStrong/typedoc#1742. This is a TypeDoc bug.

@jonchardy
Copy link
Owner

This has been resolved by TypeDoc v0.22.7.

@kainino0x
Copy link
Author

Nice! Thank you for filing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kainino0x @jonchardy