Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project with type Modules skips index.cjs #433

Open
dan-turner opened this issue Sep 1, 2023 · 3 comments · May be fixed by #434
Open

Project with type Modules skips index.cjs #433

dan-turner opened this issue Sep 1, 2023 · 3 comments · May be fixed by #434

Comments

@dan-turner
Copy link

Hi team,

In addition to this related issue where prompt.cjs wasn't working, the same is true for index.cjs, which is required for projects with "type": "module" specified in the package.json

We need to add index.cjs to the hooksfiles variable. I will submit a PR.
dan-turner added a commit to dan-turner/hygen that referenced this issue Sep 1, 2023
@dan-turner
fix: add index.cjs to list of potential config files to support modul…
337c724 
…e type packages

Closes: jondot#433
@dan-turner dan-turner linked a pull request Sep 1, 2023 that will close this issue
Open
@dan-turner
Copy link
Author

PR submitted: #434

@dan-turner
Copy link
Author

G'day @jondot! Any chance we could perhaps get this one in?

@blikblum
Copy link
Contributor

I published hygen-neo with fix similar to #434 (blikblum@e8f23c6). It has tests and improved typing

svallory pushed a commit to svallory/hypergen that referenced this issue Mar 20, 2024
@dan-turner @svallory
fix: add index.cjs to list of potential config files to support modul…
bd08a42 
…e type packages

Closes: jondot#433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add index.cjs to list of potential config files dan-turner/hygen
2 participants
@dan-turner @blikblum